search

UltCombo / ult-terminal

UltCombo's Atom terminal.
MIT License
2 stars 1 forks source link

Content no longer scrolls #14

Closed WhoBrokeTheBuild closed 8 years ago

WhoBrokeTheBuild commented 8 years ago

After the last update, the content within the terminal stopped scrolling down as it was added. I'm running a single command (grunt) that runs for a long time and continually outputs, and I have to clear the terminal now to see the latest output.

UltCombo commented 8 years ago

Are you sure you didn't accidentally scroll up at some point? The output will only autoscroll if it is already scrolled to bottom at the moment that new output is shown.

That said, I'm experiencing some odd layout issue since the last update. The output box grows more than it should and completely breaks the whole editor layout. This seems unrelated to the reported issue, though.

WhoBrokeTheBuild commented 8 years ago

I'm sure I haven't scrolled up, it doesn't allow me to scroll at all actually. I think the layout issue you mentioned might be the cause, I've been having issues with that as well.

UltCombo commented 8 years ago

Oh yeah, you're right. Looks like the layout is broken when the input box reappears. Since you are not killing the process, you just get an infinite non-scrolling element. I'm confident both issues are caused by the same layout problem.

I didn't want to put magic numbers or use JS for the <pre> element's height, so I chose to use flexbox layout. It seems that the newer Atom version has broken my flexbox layout.

WhoBrokeTheBuild commented 8 years ago

Thanks Atom, haha.

UltCombo commented 8 years ago

I simplified the layout code a bit, it seems to work as expected now.

Fixed in v0.2.1, thanks for the bug report. Please update and check if it is working as expected. :smile:

UltCombo commented 8 years ago

I forgot to reference the issue in the commit, so just in case: fixed by https://github.com/UltCombo/ult-terminal/commit/bddba277773a6b20b1264a930bd8209f57f4206c.

WhoBrokeTheBuild commented 8 years ago

I've updated and it seems to more or less do the same thing, the content still expands off the bottom of the screen and I need to clear it to see new content again.

UltCombo commented 8 years ago

That's odd. Did you restart Atom after updating? Maybe it helps.

If it doesn't, then maybe there's a conflict with your theme's style.

WhoBrokeTheBuild commented 8 years ago

That was it! Sorry about that. It seems to be working great now, thank you so much

UltCombo commented 8 years ago

No problem. :smile_cat: