Local Accounts cannot be added.

[Slddev]

Operating System

Windows, Linux, MacOS

Description of bug

Local or Ely.by accounts cannot be added.

Steps to reproduce

1. Go to manage accounts
2. Click Add Mojang
3. Click Local Account
4. Set your username in the email field.
5. Set a random password
6. Then press OK

Suspected cause

Maybe a conflict when Microsoft Support was added.

This issue is unique

• [x] I have searched the issue tracker and did not find an issue describing my bug.

[iamtakingithard]

sad!

[Slddev]

38 is mostly the one to blame here, I can try to fix it.

Edit: wow my brain hurts.

Edit 2: yep no, this is too high level for me.

[max8rr8]

I will fix, today or tomorrow

[max8rr8]

Looks like, profile fetch algorithm is completly different, this issue requires more time to fix

[zaphod77]

seems like ely.by and local need to be moved to their own classes to fix this.

Also noticed that microsoft account is greyed out, but i strongly suspect this is intentional.

having a local account from a working version doesn't help. It prompts for password, and contacts Mojang.

[MenacingPerson]

Also noticed that microsoft account is greyed out, but i strongly suspect this is intentional.

You need an MSA client ID for them, to add here: https://github.com/AfoninZ/MultiMC5-Cracked/blob/develop/notsecrets/Secrets.cpp#L31

[MenacingPerson]

Also need to add microsoft auth provider in launcher/minecraft/auth/providers maybe?

[max8rr8]

seems like ely.by and local need to be moved to their own classes to fix this.

I guess no, currently i have successful ely.by login, only one thing that doesn't work is profile id getting, but it can be fixed. Local account requires a bit more time to fix, i think about implementing fake auth server inside local server.

[zaphod77]

fake auth server should also allow lan play with local accounts, right?

[zaphod77]

ideally it should work like this.

1) launch online=legit launch. Must use legit MS or Mojang account (mojang is transitioning to MS account, so eventually mojang account will be obsolete). option for ely.by patch to enable viewing of ely.by skins. Can connect to legit and cracked servers. 2) launch offline=cracked launch. can use Local account, or Elby account. not MS or Mojang. Open to lan should allow others using the same account type to connect (local or ely.by). if launched with ely.by account, skin system will work. Skins for local account is probably too difficult. 3) allow setting TWO default accounts. one for launch (MS or Mojang), and one for launch offline (ely.by or local. do not touch mcleaks or the altening with a 10 foot pole!). alternatively remove launch offline button, and have correct decision made based on account type. ely.by account/local=offline. Mojang/MS account=online.

Am i missing something?

[MenacingPerson]

Launching online/offline is a completely different thing to online/offline accounts.

[max8rr8]

fake auth server should also allow lan play with local accounts, right?

Yes, it will, before upstream added microsoft account support i have zerotier(almost like lan) played with my friend using this cracked version

There is account type selector and depending on that we use AuthlibInjector which replaces authserver in minecraft with ely.by or local. The problem is that before launching minecraft we should get authtoken and current issue about this, instead of getting authtoken from ely.by/local(like we done it before), launcher tries to request mojang

[zaphod77]

in this version it seems to bypass the net requirement, provided you are properly authenicated already. if you aren't it asks for a password anyway.

So i'm guessing that if you have a local account working then launch offline works when net is down. another fork had a "launch offline" that is really "launch cracked" so i was a bit confused.

[Slddev]

Hi guys! Is there any update on the issue?

[iamtakingithard]

Just wait.

[Kimapr]

Anyone knows the last commit that still works? i want to use this

[max8rr8]

I guess this should work 04f580b0bc4f77b4fb4baab081bc2c356675e962 Also i am pretty sure I will this issue fix it Today

[MenacingPerson]

this is last working https://github.com/AfoninZ/MultiMC5-Cracked/commit/9069e9c9d0b7951c310fdcc8bdc70ebc422a7634

[max8rr8]

Well, ely.by login works now, local login works but very very very buggy, and to fix it i should write real http server. I will have free time on Wednesday or Thursday, so use ely.by or old version for now

[MenacingPerson]

Windows build fails

[leviska]

Can I get some older build for windows, that works, if it exists?👀

[MenacingPerson]

It's been fixed by maximmasterr, use elyby to login

[leviska]

It doesn't work for me and my friend :(

https://user-images.githubusercontent.com/14099557/139720899-301f6db3-2c9e-43a7-aab7-1d3a63cf22c3.mp4

[MenacingPerson]

You need to make an ely by account (free)

[leviska]

Ooooohhhh, thanks... But I could still play on a regular offline-mode server, yes?

[MenacingPerson]

Yes

[L0oois]

I can't login to my ely.by account on linux. does this fix only work for windows?

[MenacingPerson]

Logged in fine for me... Sounds like a layer 8 error

[L0oois]

Logged in fine for me... Sounds like a layer 8 error

what does that means?

[MenacingPerson]

logged in on linux just fine with elyby

[leviska]

try redownload the binary, it got updated just now

[L0oois]

oh ok

[MenacingPerson]

btw, the account adding button is still called "Add Mojang" but opens the normal popup

[L0oois]

yep, it works now

[L0oois]

try redownload the binary, it got updated just now

thank you

[iamtakingithard]

Nice, KDE @Samisafool

[MenacingPerson]

thanks?

[max8rr8]

AND IT IS FIXED, at least for me it works. Please check fixes and report here.

[MenacingPerson]

It seems to be fine, but the type shows as "Mojang"

Edit: I wonder if this can be fixed as well?

[lebestnoob]

It seems to be fine, but the type shows as "Mojang"

Edit: I wonder if this can be fixed as well?

I don't know if it still applies to this version, but in the older builds, before the debranding, I could add -Dauthlibinjector.noShowServerName to the java arguments to disable the localhost message in the menu screen.

[MenacingPerson]

Still works. Any chance of passing it by default to make it more pretty?

Edit: also works in F3 menu

[max8rr8]

Everything fixed, if you find any new bugs related to this, open new issue

It seems to be fine, but the type shows as "Mojang" Fixed

Still works. Any chance of passing it by default to make it more pretty? Nope, i think we shoul display this, it helps to understand what provider this instance for, but we should add note about option how to disable this to README.

[MenacingPerson]

I'll make a PR that fixes the README. The last one got rejected because I was dumb. (A fool, if you will)