Ultimaker / Cura

3D printer / slicing GUI built on top of the Uranium framework
GNU Lesser General Public License v3.0
6.19k stars 2.08k forks source link

Silent installation is not silent. Adafruit Industries device software requires interactive console #10091

Open basictheprogram opened 3 years ago

basictheprogram commented 3 years ago

Application Version

4.10

Platform

Windows 10

Printer

N/A

Reproduction steps

From an Admin powershell

Ultimaker_Cura-4.10.0-amd64.exe" /S

Actual results

Would you like to install this device software for Adafruit Industries dialog is displayed and requires an interactive console.

image

Expected results

Silent install should be silent.

Checklist of files to include

Additional information & file uploads

No logs, no project file, the problem is with doing a silent installation.

basictheprogram commented 3 years ago

I've run into a similar problem in the past, documented at https://github.com/Ultimaker/Cura/issues/1245

And pristine Windows10 install the same problem identified in https://github.com/Ultimaker/Cura/issues/1245 reappears.

Regression?

Do some git blame and see if I can find where things got changed.

chocolatey_test_environment_windows_10__Running_

https://github.com/Ultimaker/cura-build/blob/4.10/cmake/NSIS.template.in indicates the arduino drivers should not be installed in silent mode, was 4.10 build with the NSIS.template.in that's on the 4.10 branch?

basictheprogram commented 3 years ago

Just noting my security guys complaining. Signature expired 01/12/2020

chocolatey_test_environment_windows_10__Running_
fvrmr commented 3 years ago

Hi @basictheprogram I will bring this up for discussion with the team. Keep you posted!

basictheprogram commented 3 years ago

Work around for /me/ is discussed here: http://disq.us/p/2i28wrk and the code to insert the certificates before doing the installation can be found at https://github.com/basictheprogram/chocolatey-cura-new/tree/4.10

evtrados commented 3 years ago

Hi @basictheprogram ,

I've tried to reproduce this issue locally on two PCs, but I couldn't. I naturally had already the Arduino related drivers installed on my systems, so I first removed them completely. After opening a cmd.exe shell as an Administrator and tried to silently install the Cura v4.10 .exe installer (which I downloaded from the official Ultimaker website) I had no issues whatsoever. As a matter of fact the Arduino-related drivers were installed automatically:

Arduino_drivers

We should update the license of all these certificates though, since they've all expired for some time now:

certs

basictheprogram commented 3 years ago

Hi @evtrados,

I found that removing the certificates via the certificate manager and rebooting was not enough. Like you, the next silent installation worked as expected.

But a pristine windows install, I'm using vagrant and https://github.com/StefanScherer/packer-windows, it does still throw the alert dialog for both the AdaFruit and Arduino certificates.

I can also confirm on 2 new laptops (Lenovo) demonstrate same behavior. The alert dialog for both the AdaFruit and Arduino certificates.

I am also confused why removing the certificates does not work as expected.

I am happy to test more, using vagrant, virtualbox, and Windows10 if you tell me what else I can do.

Here is a blurry screen capture of installing 4.10 onto a pristine Windows10 vagrant box.

https://user-images.githubusercontent.com/6723257/124803747-1d17a080-df1f-11eb-8ddd-e0d55535dbeb.mp4

w0 commented 3 years ago

I am experiencing the same behavior as @basictheprogram on windows computers that have not previously installed the drivers.

evtrados commented 3 years ago

We discussed this with the team and decided that the issue is important enough to be in our backlog and eventually be fixed. Developers, please see internal ticket CURA-8387.