Ultimaker / Cura

3D printer / slicing GUI built on top of the Uranium framework
GNU Lesser General Public License v3.0
6.22k stars 2.08k forks source link

Seam corner preference 'none' not working....keeps corner priority #12355

Open PhilBaz opened 2 years ago

PhilBaz commented 2 years ago

Application Version

5.0

Platform

win 10

Printer

Voron 2.4

Reproduction steps

Seam corner preference 'none' and set coordinates for center of object.

Actual results

Seam lands on corner

Expected results

Seam should land on object wall....near the center of the wall in this case.

Checklist of files to include

Additional information & file uploads

Screenshot 2022-05-25 212332 Seam corner preference 'none'.zip

Asterchades commented 2 years ago

The mainstream build of Cura will only ever put seams in corners. The preference is simply to dictate which type of corner. Yes, that does make the presence of both "Hide or Expose Seam" and "None" superfluous given they both achieve the same result, and I suspect that's a legacy hold-over from a time where things may have been different.

What does look unexpected in that picture, however, is that the seams on the front piece aren't all on the same corner the way they are on the back. Given the settings you've shown they should all be on the inner edge. Cura has been struggling with that for longer than just 5.0, however - especially on "rounded" surfaces - for reasons I can only guess.

smartavionics commented 2 years ago

FWIW, my cura builds are capable of placing the z-seam not on a corner when the seam preference is set to user defined and the corner preference set to none.

smartavionics commented 2 years ago

Screenshot_2022-05-26_11-09-59

smartavionics commented 2 years ago

Here's an example of how this feature can help, compare these two images...

Screenshot_2022-05-26_11-13-33

Screenshot_2022-05-26_11-13-56

PhilBaz commented 2 years ago

@smartavionics @Asterchades

Yes, they also line up perfectly!

I think it would be highly advantageous for Cura 5 to maintain a non-corner seam functionality. It is not always the preferred location for from a functional or aesthetic perspective. For instance, on my example piece, the inside surface will be hidden by another assembly, while all corners and the outer surface will be exposed.

@Asterchades will this bug report be enough, or should I file a accompanying feature request? Funny enough the feature is already there, but its just not working.

PhilBaz commented 2 years ago

Screenshot 2022-05-26 091536

Asterchades commented 2 years ago

I would imagine this report should be sufficient - it's the same people that deal with both, after all. It's not unreasonable to expect that two different options will yield two appreciably different results, even if sometimes similar, and "None" to me does feel like it shouldn't be preferring corners at all (though not actively avoiding them).

As I already mentioned, though, there's something funky with Cura's seam location decisions in general. Two identical layers shouldn't produce seams in different places unless the seam is explicitly configured as such (ie Random). Obviously this design doesn't have identical layers but something that fundamental wouldn't be helping in this situation either.

PhilBaz commented 2 years ago

Has this been picked up by the Cura team ?

Seam placement in general is one of the biggest issues with Cura 5.

Screenshot 2022-06-25 105916

Joeydelarago commented 2 years ago

Hello, we will discuss this seam issue. I agree the seam should be placed the same as earlier versions with this setting configuration.

PhilBaz commented 2 years ago

@Joeydelarago Hi joey, thank you! There are two issues currently. 1) we need non-corner preference for full control, setting seam by coordinates, exactly where they are desired. 2) Currently all seams are not straight. Slice a cylinder and you don't get a straight seam down, there will be deviation left and right.

Ghostkeeper commented 2 years ago

Developers, see issue CURA-9474.

tlhintoq commented 2 years ago

image

Personal guess... Seam placement insists on disabling the option to even choose "none". Its insists on trying to place at "back". Which I suspect it looks for where the back is in real time while slicing and comes up with a different number on every layer, so its all over the place.

In 4.13 we could actually set "none". In 5.0/5.1 we can't. Cura5-Seam

jellespijker commented 2 years ago

see also the FR in CuraEngine https://github.com/Ultimaker/CuraEngine/issues/1702

MariMakes commented 6 months ago

Quick update, we are looking into ways to improve this for the upcoming release. You can already take a sneak-peak here https://github.com/Ultimaker/CuraEngine/pull/2087