search

Ultimaker / Cura

3D printer / slicing GUI built on top of the Uranium framework
GNU Lesser General Public License v3.0
6.07k stars 2.06k forks source link

Pressing "Escape key" while in "discard or keep changes" window will save current changes. I don't think this should be a thing. #15601

Open Genox666 opened 1 year ago

Genox666 commented 1 year ago

Application Version

5.3.0

Platform

Windows 10

Printer

Creality Ender-5 Plus

Reproduction steps

  1. Open "Print settings" popup menu at the right.
  2. Change any settings you want to configure.
  3. Click the blue "Compare and save." icon at the top of the menu.
  4. Once you are done looking at the changes you made, press the "Escape key" to close the window.

Actual results

The window is closed and the changes have been saved as if you had clicked on the "Save" button.

Expected results

The window closes and the changes are not saved. Same as manually clicking on the red X in the upper corner of the window.

Image1: Print settings window with a modification to the profile image

Image2: Discard or keep changes window before pressing escape image

Image3: Print settings window after pressing escape image

Checklist of files to include

Additional information & file uploads

There's really not much more to it than previously described.

MariMakes commented 1 year ago

Hey @Genox666,

Welcome to the UltiMaker Cura Github 🚀 Sorry, it took us a while to get back to you 😞

I don't use profiles that often, so I haven't encountered this, but I can reproduce your issue on my side. Recording #48 But only if I work with custom profiles, not with the default ones. I agree that it's weird that saving is the default behavior for the escape button in this case. 😮

I'll bring it up to the team to see what they can do to improve it. But I expect that if it's not a quick fix that it will not get a high priority to implement. Fingers crossed 🤞

Genox666 commented 1 year ago

Thank you for your reply! Not a major problem, simply a required adaptation. Fingers crossed 🤞 indeed.

MariMakes commented 1 year ago

Quick update from our side 👋

We've added a ticket to the backlog with the intent to improve this. For internal reference CURA-10672

Thanks for the report! 👍

Bzzz commented 9 months ago

This f*cked me over today big time with a dozen of experimental settings on an otherwise fine profile (and of course no backup) - please fix...

andrewroth commented 1 week ago

+1. This has thrown me off as well.

Genox666 commented 1 week ago

+1. This has thrown me off as well.

I strongly suggest you switch to Orca Slicer, this is now the go to in terms of slicer software for pretty much any and most machines. You won't have as many issues with it.