search

Ultimaker / Cura

3D printer / slicing GUI built on top of the Uranium framework
GNU Lesser General Public License v3.0
6.21k stars 2.08k forks source link

AGPLv3 still in comments? #15731

Open sp7412 opened 1 year ago

sp7412 commented 1 year ago

Application Version

5.3.1

Operating System

Windows

Printer

Ultimaker

Reproduction steps

I see that Cura is released under GNU Lesser General Public License v3.0 (https://github.com/Ultimaker/Cura/blob/main/LICENSE) and that the license changed from AGPLv3 to LGPLv3 in 2017 (https://github.com/Ultimaker/Cura/commit/9a193ad5c5ab5324ad1335dd9adf80fef24a7977).

But I still see AGPLv3 in the header of this file https://github.com/Ultimaker/Cura/blob/main/plugins/PostProcessingPlugin/PostProcessingPlugin.py#L2

Was this file missed when Cura went from GPLv3 to LGPLv3 in 2017?

Actual results

N/A

Expected results

N/A

Checklist of files to include

Additional information & file uploads

N/A

fieldOfView commented 1 year ago

The PostProcessing plugin was originally a separate project, released under the AGPL: https://github.com/nallath/postprocessingplugin

It looks like the plugin was merged into the Cura project (6c0fb110fe842758c7cc20dae7edc055d5c8ad8c) after the change in license on the Cura repository. So that leaves the Cura project with a mixed license at the moment.

sp7412 commented 1 year ago

@nallath

MariMakes commented 1 year ago

Hey @sp7412,

Thanks for your report 👍 Excellently spotted 🔎

I'll bring it up to the team to see how they can update it.

nallath commented 1 year ago

The company owns the code that the developers worked on, they can switch from AGPL to LGPLv3 without needing individual permissions (although in this case, Ultimaker did already explicitly obtain mine and of the other UM developers that worked on it)

The main license is Cura has usually have the final say, and that one was changed by Ultimaker to LGPLv3. But, if this post processing plug-in seems to have been forgotten by accident, it's a good idea to fix it ASAP. We believe that the only permission we need to upgrade is from Christophe Baribaud for the Stretch plugin, and we've received written confirmation that he agrees to change the license.

fieldOfView commented 1 year ago

Technically, I was never asked permission to change the license of my contributions to the Postprocessing plugin repository after october 2016. My contributions before that date could be seen as owned by Ultimaker. If you want my permission, then just ask.

nallath commented 1 year ago

Err. You are right. I overlooked that. Mea culpa!

So, Do you mind changing it to LGPL?

fieldOfView commented 1 year ago

You have my permission to relicense my contributions to the postprocessing plugin.