search

Ultimaker / Cura

3D printer / slicing GUI built on top of the Uranium framework
GNU Lesser General Public License v3.0
6.19k stars 2.08k forks source link

Profile Name Lenght suddenly shorter, need longer length support for profile names #19110

Open BloodyIron opened 5 months ago

BloodyIron commented 5 months ago

Cura Version

5.7.0

Operating System

Ubuntu Linux

Printer

NA

Reproduction steps

I used to be able to use much longer names for printing profiles, and now I have a much more limited character length. I need to be able to use much longer printing profile names so I can accurately describe ones I make. Can we please have a much longer character limit supported for printing profiles that we make?

Actual results

asdf

Expected results

Not having an absurdly short character limit for the name of profiles.

Add your .zip and screenshots here ⬇️

na

BloodyIron commented 5 months ago

Just to be clear the character limit is currently 40, but previously I was able to use double that without hitting the limit. 40 is an extremely short length and really in the era of 64bit computing, we can safely support longer bytelengths.

GregValiant commented 5 months ago

Thanks for the report. I went back to 4.13.1 and the Rename Dialog had a 40 character limit there but other dialogs and text boxes that used the Profile Name didn't seem to have the limit. I don't see a bug here because the dialog is working as it was written. I think this should be a "Feature Request" to increase the character limit.

I altered "RenameDialog.qml" (line 66) from "maximumLength: 40" to "maximumLength: 120" and it seemed to work. When fooling around like that there can be "unexpected consequences" so if you alter it and forget what you did be aware that there might be some breakage down the line. I did save a project file with the 120 character name in 5.7.1 and opened it in 5.5 and 4.13.1. The long name was truncated to 40 characters by the "Rename Dialog" but it did load.

I'll remove the bug label from this as it is simply the way it works. I'll leave this open and change it to a "feature request". I've mentioned 120 characters. What do you feel would be sufficient? Understand that the number of textboxes involved is > 1 and I don't think any of them are multi-line so they might not "grow" to accommodate the longer names. The Cura team will need to research that.

BloodyIron commented 5 months ago

I would classify it as a bug as I was previously (in previous versions of Cura, do not know which ones specifically) able to name a Profile more than 40 characters, but those profiles now cannot be modified to something more than 40 characters. So it is a rather tangible regression in functionality, er-go a bug.

I would rather this be corrected in the core application itself instead of using a work-around as you propose, for the fragility reasons you outline too.

Please re-add the bug label as this is a conclusive regression that is tangibly reproducible, from a User eXperience perspective.

As for what would be sufficient, why not just set it to 255/256 and let that be? I don't know what my actual maximum could be, but 255 or 256 would be plenty for me, and that then is a power of 2, isn't that preferable for such things? ;)

As for not-multi-line yeah I can appreciate that aspect, and this topic could expand in nature, which is also understandable. But 40-char is significantly limiting.

Thanks for your engagement! :)