search

Ultimaker / Cura

3D printer / slicing GUI built on top of the Uranium framework
GNU Lesser General Public License v3.0
5.95k stars 2.04k forks source link

CURA-11937 Default layer start position to machine_extruder start position #19283

Open wawanbreton opened 4 days ago

wawanbreton commented 4 days ago

We have 2 settings that are used to setup initial positions in the engine: machine_extruder_start_pos_x/y and layer_start_x/y. They are used in different contexts, however it would make sense that they are setup accordingly. Thus I added a default value for the layer_start position, which is usually not defined, to match machine_extruder_start position.

:warning: The settings layer_start_x/y are defined in fdmprinter.def.json, but the machine_extruder_start_pos_x/y are defined in fdmextruder.def.json. The implementation currently works, but I'm not sure this is actually a valid setup. An other option would be to use an average position of all the extruders start position (which is already done for UM printers and an other 3rd party).

CURA-11937

wawanbreton commented 3 days ago

Ok, did that, it is probably safer indeed. And this way we can remove the overrides that had this formula as a definition.