Relative Extrusion is ignored when importing G-Code

Ultimaker / Cura

3D printer / slicing GUI built on top of the Uranium framework

GNU Lesser General Public License v3.0

6.07k stars 2.06k forks source link

Relative Extrusion is ignored when importing G-Code #19514

Open EmJay276 opened 1 month ago

EmJay276 commented 1 month ago

Cura Version

5.7.1

Operating System

Windows 10

Printer

All

Reproduction steps

Slice any model with relative extrusion setting
Import the G-Code

Actual results

grafik

Expected results

grafik

Add your .zip and screenshots here ⬇️

gcode.zip

smartavionics commented 1 month ago

A quick look at the Cura 4 code shows that it only recognises relative extrusion (due to M83 in gcode) when the gcode flavour is RepRap.

GregValiant commented 1 month ago

I see the same thing (looking in FlavorParser.py) and the behavior does appear to go back to at least 4.13.1. Arc Welder's G2 and G3 lines continue to be unsupported as well.

EmJay276 commented 1 month ago

Should adding these lines to the "general" FlavorParser.py not just fix it? https://github.com/Ultimaker/Cura/blob/e3287a1c161b63c75bc3dfd82257c0c5c2a69dca/plugins/GCodeReader/RepRapFlavorParser.py#L14-L20

EmJay276 commented 1 month ago

I just tested it in my local installation, and yes, it does fix it. I will create a PR.

EmJay276 commented 1 month ago

You can test it in https://github.com/Ultimaker/Cura/pull/19515 if you want 👍