Ultimaker / Cura

3D printer / slicing GUI built on top of the Uranium framework
GNU Lesser General Public License v3.0
6.1k stars 2.06k forks source link

Avoid Actions.qml cyclic dependency #19654

Open dfries opened 2 weeks ago

dfries commented 2 weeks ago

Description

qt.qml.typeresolution.cycle: Cyclic dependency detected between "File:///Cura/resources/qml/Actions.qml" and "file:///Cura/resources/qml/Actions.qml"

Create a different namespace for Actions to import that has the dependencies it needs, but one that Actions isn't already part of.

While this solution works, I don't know what is extra special about Actions.qml that it can't import Cura without "Cyclic dependency detected" and other components like Menus/MaterialMenu.qml which is registered in cura/CuraApplication.py as a part of qmlRegisterType(QUrl.fromLocalFile(path), "Cura", 1, 0, type_name), but it seems to be okay.

Type of change

How Has This Been Tested?

Test Configuration:

Checklist: