Ultimaker / Cura

3D printer / slicing GUI built on top of the Uranium framework
GNU Lesser General Public License v3.0
6.13k stars 2.07k forks source link

Better seam approach #19805

Open Hello1024 opened 1 day ago

Hello1024 commented 1 day ago

Is your feature request related to a problem?

Better approach to seams being visible.

Describe the solution you'd like

Make the seam be gradual by starting the extrusion from inside the shape, gradually increasing flow rate and moving outwards, doing one complete lap of the object, and then reducing the flow and moving inwards again to finish.

Like this: image

Describe alternatives you've considered

Scarf seams didn't work well for me.

Affected users and/or printers

Everyone.

Additional information & file uploads

I have implemented this (very roughly!)

See here: https://github.com/Hello1024/CuraEngine/tree/Hello1024-better-seam

It works well:

my implementation: PXL_20241025_114411244

regular seam: PXL_20241025_100624474

scarf seam: PXL_20241025_100635950 MP

I wont have time to bring this code up to quality for contributing to the project, but wanted to document that this approach works, and as well as getting rid of the seam, also has a ~5% print time saving due to reduced travel moves and the travel moves having no 90 degree edges which regular perimeters have.

@wawanbreton who might be interested.

wawanbreton commented 1 day ago

Hi @Hello1024,

Thanks for the report, this is extremely interesting indeed :slightly_smiling_face: We did a try for a different approach move a few months ago, but parked it because we had many edge-cases and did not give that good results. But your approach looks very much like a scarf seam, but in the XY plan instead of Z. So it could actually be added to our actual scarf seam algorithm very easily (quite like you did actually). I'll probably give it a try.

However, I think there may be a patent on this technique, in which case we would not be allowed to implement it. I may be mixing it up with something else though, I'll check with the team on Monday.

Hello1024 commented 1 day ago

@wawanbreton please look in detail at this diff. I believe that resolves your concerns, but if it doesn't it's probably a 5 min offline topic.

wawanbreton commented 1 day ago

I believe that resolves your concerns

I fail to see how :thinking: I would have made a setting of this distance tbh, since this is typically the kind of thing that people will want to customize.

Hello1024 commented 1 day ago

That specific number is critical to the patent you referenced. All numbers 2 or below would violate the patent.

In my experience, ideal print quality is achieved at 2, but you get decent results all the way between 1 and 4. 2.1 seems like the best compromise, and obviously the 10 micrometer difference wont affect print quality.