Ultimaker / Cura

3D printer / slicing GUI built on top of the Uranium framework
GNU Lesser General Public License v3.0
6.18k stars 2.08k forks source link

Print Settings Hide Save Dialog #6399

Open thesec opened 5 years ago

thesec commented 5 years ago

Since release of v4 the print settings come at full height, hiding the - now separate - save dialog: Screenshot 2019-09-23 at 15 33 18

Please limit the settings' height to leave space for the dialog underneath as before so I do not have to close them prior being allowed to save.

smartavionics commented 5 years ago

But you can drag the bottom of the settings by grabbing the three dots so you can alter the height of that panel.

fieldOfView commented 5 years ago

Or you can install the Sidebar GUI plugin, which properly fixes this foolishness

thesec commented 5 years ago

Hihi, excellent @smartavionics ... I just did not wear my jeweller's magnifiying lens to realize there being three fly sh... for dragging the panel in such a non-standardized fashion ;)

Yet I will leave this open. It should neither require a lens on the nose, nor user interaction or even a plugin to get around this.

rburema commented 5 years ago

Also you can drag the panel around with the header.

rburema commented 5 years ago

Shouldn't be completely full height though, it should stop (unless someone drags it) right above the 'action panel' (the one with the slice button in it).

Do you have multiple different sized monitors you work on? Was it always like this since first startup of 4.0.0?

thesec commented 5 years ago

@rburema - it was always like it. Yes, I have two differently sized displays I work on.

Ghostkeeper commented 5 years ago

This was brought up during the design of the new interface for 4.0 as well. Back then we didn't implement this for architectural reasons: In this window we don't have access to the UI element for the action panel in the bottom right. It could be implemented but you'd get an expression like this (semi-pseudocode):

max_height = window_height - UM.Theme.getSize("default_margin").height * 4 - UM.Theme.getSize("thin_margin").height * 2 - UM.Theme.getSize("lining").height * 4 - UM.Theme.getSize("action_panel_widget").height - UM.Theme.getSize("stage_menu").height ...

This was deemed to be unmaintainable.

thesec commented 5 years ago

I get the maintability issue from the above technical perspective, thank you.

Yet it seems not a minor issue if you already had this in your discussions and someone already invented the energy to work around it with an addon.

There are multiple solutions that are more maintainable like e.g.

That'll be an interesting task for the UI designers :)

thesec commented 5 years ago

...

Ghostkeeper commented 5 years ago

making the bottom offset simply use a default height that'll simply cover the expected height of the dialogue underneath

Yeah, that was the proposed solution but as you can see it was complex. Or rather not necessarily complex but hard to oversee when there is a change and if it works for all sizes of the panel.

an icon that is more obvious than the rotated hamburger (does it make it a hot dog? a sandwich?), see https://www.visualpharm.com/free-icons/mouse/drag%20mouse for commonly used ones

We're using the same grippy dots as in many web and mobile applications. For instance look at g-mail. That was the idea anyway.

tablatronix commented 5 years ago

This new UI has some annoyances, mostly that it makes all the UI elements on total opposite sides of the screen, everything is as far away from each other as possible.

The time slider and layer sliders should be next to each other, this pushes one all the way to the right, going back and forth is a pain. Controls are all the way on the left, viewport, all the way on the bottom, view control top left, layer control, the whole top, but the dialog is on the left ?

God forbid you have one of those widescreen monitors... lol

And an actual BUG The floating side bar covers the layer # popup..

fieldOfView commented 5 years ago

There is the Sidebar GUI plugin in the Marketplace, which solves most of these issues.

tablatronix commented 5 years ago

@fieldOfView I know I installed it, it was awesome to have it back!, but I turned it off for a bit while I narrow down the source of my performance issues, not sure if it was related or not

fieldOfView commented 5 years ago

OT: So, was it the cause of the slowdowns?

Ghostkeeper commented 5 years ago

And an actual BUG The floating side bar covers the layer # popup..

Yeah, we found that as well and fixed it in Cura 4.4. See https://github.com/Ultimaker/Cura/pull/6499 and https://github.com/Ultimaker/Cura/pull/6592.

Edit: No actually those are about the action panel hiding the layer slider on small screens. For the floating settings panel we still don't have a real solution.

tablatronix commented 5 years ago

So you fixed this? Screen Shot 2019-11-04 at 12 17 20 PM

Ghostkeeper commented 5 years ago

No, as I said, for the floating settings panel we still don't have a real solution. Other than moving the panel a bit to the left, that is. It should remember the location relative to its original location.

nallath commented 5 years ago

So you fixed this?

We have a solution for it in https://github.com/Ultimaker/Cura/pull/6607

rburema commented 5 years ago

That's pulled into master though, so it's not in 4.4