search

Ultimaker / Cura

3D printer / slicing GUI built on top of the Uranium framework
GNU Lesser General Public License v3.0
6.07k stars 2.06k forks source link

3mf project files don't get a model check for errors #9588

Open GregValiant opened 3 years ago

GregValiant commented 3 years ago

Application Version

4.8.0 4.9beta

Platform

Win 10

Printer

Creality E3Pro

Reproduction steps

  1. Open a 3mf file that includes a model that has errors.

Actual results

The "model is not watertight" warning doesn't come up. I opened the attached 3mf file. There was no warning. Just to check, I exported the model from Cura as a binary STL and then cleared the build plate and brought the STL in to Cura and the warning did pop up. This is a model from issue #9567. E3PROSKR_eagle-Body3_LW-profile3_PPPLWPLA-0-00-025.zip

Expected results

The "model is not watertight" warning will come up as it does when an STL file with errors is opened.

fvrmr commented 3 years ago

Hi @GregValiant thank you for your bug report. I will discuss this with the team. Keep you posted!

Ghostkeeper commented 3 years ago

I couldn't reproduce this bug. I tried it with a 3MF file of my own first: image

And also with the project file in this ticket: image

But I think I know what the issue is here. The frequency at which the check for model errors occurs was significantly reduced in Cura 4.8, for performance reasons: https://github.com/Ultimaker/Cura/commit/333b2959cd8c43bd580226bb5dfe0fb17587cf93 So it takes up to 30 seconds for the message to appear. That is really quite a lot! Should we maybe also trigger a check just after the file is loaded, to catch 90% of the cases within a fraction of a second?