Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.69k stars 886 forks source link

[BUG] Cura 5.0: Ironing always uses T2 when Ironing Pattern is set to "Concentric" and printing extruder is T3 or T4 #1726

Closed vwpollen closed 2 years ago

vwpollen commented 2 years ago

Application Version

5.0.0

Platform

Mac OS 10.15.7

Printer

Custom FFF printer with 4 extruders

Reproduction steps

  1. Select a printer that have 3 or 4 extruders. I have tested the built-in custom FFF printer with 4 extruders.
  2. Open an simple STL (hexagon)
  3. Select T1 as the active extruder to print the hexagon, tick "enable ironing", select "Zig-Zag" ironing pattern, slice and check that ironing is made with T1 (GOOD)
  4. Change ironing pattern to "Concentric", slice and check that ironing is made with T1 (GOOD)

T2 tests:

  1. Select T2 as the active extruder to print the hexagon, tick "enable ironing", select Zig-Zag ironing pattern, slice and check that ironing is made with T2 (GOOD)
  2. Change ironing pattern to "Concentric", slice and check that ironing is made with T2 (GOOD)

T3 tests:

  1. Select T3 as the active extruder to print the hexagon, tick "enable ironing", select Zig-Zag ironing pattern, slice and check that ironing is made with T3 (GOOD)
  2. Change ironing pattern to "Concentric", slice and check the ironing: it is now made with T2 instead of T3 (WRONG)

T4 tests:

  1. Select T4 as the active extruder to print the hexagon, tick "enable ironing", select Zig-Zag ironing pattern, slice and check that ironing is made with T4 (GOOD)
  2. Change ironing pattern to "Concentric", slice and check the ironing: it is still made with T2 instead of T4 (WRONG)

Actual results

When printing with T3 or T4, ironing using "Concentric" pattern change tool to T2 for the ironing.

Expected results

When printing with T3 or T4, ironing using "Concentric" pattern should make the ironing with the same tool, "Zig-Zag" ironing pattern works as expected.

Checklist of files to include

Additional information & file uploads

Please find below a few illustrative pictures 01 concentric T2 01 concentric T3 02 zigzag T3 03 concentric T4 04 zigzag T4 .

MariMakes commented 2 years ago

Hey @vwpollen,

Welcome to the Ultimaker Cura Github 🚀

This seems like something that has slipped in by accident. 😮 I'll check with the team if they know what might be causing this. But I suspect that if it's not a quick fix we'll probably not work on issues that involve more than 2 extruders.

But since Cura is open source, you or anyone else is more than welcome to work on this issue and create a pull request yourself. Fingers crossed 🤞

vwpollen commented 2 years ago

Thank you for giving an eye and trying to debug it. Let me know if anything obvious gets from your investigation, otherwise I can have a deep look at the code myself.

rburema commented 2 years ago

That was an easy one. Committed directly to main. If you're curious to see what the problem was, please see the commit referenced above.

vwpollen commented 2 years ago

Great! Thanks for your time and improving Cura !