Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.67k stars 880 forks source link

Boolean logic error in LayerPlan::computeCombBoundary #1879

Closed thecampbells384 closed 1 year ago

thecampbells384 commented 1 year ago

is infill OR anti_overhang, not if mesh is infill AND anti_overhang.

Description

Previously the comb boundary was not calculated if the mesh was both an infill_mesh AND an anti_overhang_mesh. I'm quite sure that it was intended for this to in fact be if the mesh was either an infill_mesh OR an anti_overhang mesh.

Type of change

How Has This Been Tested?

I have ran cura with the relevant changes and seen no untoward effects. To be fair, I had not seen any untoward effects before the changes either.

Test Configuration:

Checklist:

rburema commented 1 year ago

Thanks for your contribution!