Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.67k stars 880 forks source link

[CURA-10500] simplify fixes #1885

Closed rburema closed 1 year ago

rburema commented 1 year ago

Things that where probably causing jagged edges:

At the moment I think this is enough to not introduce jaggies into polygons or polylines that are not themselves fine details. There are still some small lines that ping the checker, bit those seem a bunch of small polylines (which have fixed endpoints) that you'd need to have one or more special cases for, since you either do need to remove the end-points then, or accept that in those cases some deviation is accepted (like throwing away paths that are not by much, but still, above the minimum length).

github-actions[bot] commented 1 year ago

Unit Test Results

25 tests  ±0   25 :heavy_check_mark: ±0   15s :stopwatch: -1s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit e6ba62ed. ± Comparison against base commit 7b905648.

:recycle: This comment has been updated with latest results.