search

Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.68k stars 883 forks source link

[CURA-10805] unify plugin slot calls #1910

Closed rburema closed 1 year ago

rburema commented 1 year ago

Clean up the different ways which basically all come down to just 'slot identification' by unifying all (at least to the 'outside world' -- the non-plugin parts) by always using SlotID as an identifier.

github-actions[bot] commented 1 year ago

Unit Test Results

26 tests  ±0   26 :heavy_check_mark: ±0   13s :stopwatch: -3s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 7f1fb085. ± Comparison against base commit 5dd9dbda.

:recycle: This comment has been updated with latest results.

rburema commented 1 year ago

Closed in favour of these two: