Closed jellespijker closed 1 year ago
26 tests ±0 26 :heavy_check_mark: ±0 16s :stopwatch: +2s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0
Results for commit 4b88ec47. ± Comparison against base commit 5fd4e1c6.
:recycle: This comment has been updated with latest results.
Description
Alternative implementation of CURA-10805 as implemented in #1910 Don't merge this yet, since this PR is only tested by compilation and not by actually testing it.
See also: https://github.com/Ultimaker/CuraEngine_grpc_defintions/pull/9
Type of change
Biggest difference between the two PR's are:
slot_id
such that we can call the modify and broadcast with theslot_id
TODO
Cura.proto
in Curaslot_postprocess
andslot_simplify
either needs to be renamed toslot_postprocess_modify
andslot_simplify_modify
orslot_settings_broadcast
needs to be renamed toslot_settings
Not sure which is the better naming scheme.How Has This Been Tested?
Test Configuration:
Checklist: