Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.67k stars 880 forks source link

Cura 10805 unify modify broadcast slots calling #1913

Closed jellespijker closed 1 year ago

jellespijker commented 1 year ago

Description

Alternative implementation of CURA-10805 as implemented in #1910 Don't merge this yet, since this PR is only tested by compilation and not by actually testing it.

See also: https://github.com/Ultimaker/CuraEngine_grpc_defintions/pull/9

Type of change

Biggest difference between the two PR's are:

TODO

How Has This Been Tested?

Test Configuration:

Checklist:

github-actions[bot] commented 1 year ago

Unit Test Results

26 tests  ±0   26 :heavy_check_mark: ±0   16s :stopwatch: +2s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 4b88ec47. ± Comparison against base commit 5fd4e1c6.

:recycle: This comment has been updated with latest results.