Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.66k stars 876 forks source link

Cura 10811 improve smooth #1928

Closed casperlamboo closed 11 months ago

casperlamboo commented 11 months ago

This includes updated fluid motion logic. A new definition of fluid motion is introduced, here a tool-path-part is considered to be fluid if all of the following criterial hold a) Vectors [A,B] and [C,D] are "long" (settable through settings) b) Vector [B,C] is "short" (settable through settings) c) either on the angles between vectors

Unit tests are added, both to show intent of the isSmooth predicate and to test against future regressions.

Cura-10811

github-actions[bot] commented 11 months ago

Unit Test Results

26 tests   26 :heavy_check_mark:  18s :stopwatch:   1 suites    0 :zzz:   1 files      0 :x:

Results for commit 023037a0.

:recycle: This comment has been updated with latest results.

jellespijker commented 11 months ago

@casperlamboo might be best if you close this PR and open a new one. The Workflow should be disabled now