Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.

https://ultimaker.com/en/products/cura-software

GNU Affero General Public License v3.0

1.68k stars 882 forks source link

Cura 10916 fix layer index #1932

Closed jellespijker closed 1 year ago

jellespijker commented 1 year ago

Description

Make sure that LayerIndex is it's own integral type and don't inherit from numeric facade, A lot of conversion problems, because LayerIndex + integral-> NumericFacade

Als ensured that the Cura Arcus types used int64

github-actions[bot] commented 1 year ago

Unit Test Results

26 tests 26 :heavy_check_mark: 10s :stopwatch:   1 suites   0 :zzz:   1 files   0 :x:

Results for commit c2b8cdfc.

:recycle: This comment has been updated with latest results.

rburema commented 1 year ago

Seems like the fail in the analyzer doesn't have anything to do with this PR at least.

rburema commented 1 year ago

Ah, I remember seeing the return types weren't templated. That should have rung a bell.

LGTM.