Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.66k stars 876 forks source link

CURA-8889_fix_one_at_a_time_initial_temperature #1940

Closed wawanbreton closed 10 months ago

wawanbreton commented 10 months ago

Bed temperature was not applied after the first model being printed. Only for Griffin-flavored GCode printers (which includes UltiMaker printers).

github-actions[bot] commented 10 months ago

Unit Test Results

26 tests   26 :heavy_check_mark:  10s :stopwatch:   1 suites    0 :zzz:   1 files      0 :x:

Results for commit 14c3036d.

wawanbreton commented 10 months ago

Thanks, I tried to investigate the benchmark crash, and it also happens on the main branch. Should we wait for a fix before we can merge this one ?

wawanbreton commented 10 months ago

Ok, I have my answer :)

rburema commented 10 months ago

@wawanbreton Haha, within the same minute, even. The same, unrelated, benchmark crash is happening for a lot of branches. We should fix that soon, but since this isn't something I'd expect any changes in the benchmark from, we can just ignore it for now.