[CURA-11035] Plugins specify a verion-range, slots just a version.

Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.

https://ultimaker.com/en/products/cura-software

GNU Affero General Public License v3.0

1.68k stars 882 forks source link

[CURA-11035] Plugins specify a verion-range, slots just a version. #1952

Closed rburema closed 1 year ago

rburema commented 1 year ago

Not the other way around as we have now. This also adheres closer to the way we handle front-end plugins. Ideally you'd maybe want both of them to be ranges, but that's for the future.

github-actions[bot] commented 1 year ago

Unit Test Results

26 tests ±0 26 :heavy_check_mark: ±0 12s :stopwatch: ±0s   1 suites ±0   0 :zzz: ±0   1 files ±0   0 :x: ±0

Results for commit 803c2d91. ± Comparison against base commit 52cc0d89.

:recycle: This comment has been updated with latest results.

rburema commented 1 year ago

LGTM; A couple of smaller remarks on the other PR's tho

Hi @jellespijker ! I keep meaning to ask today, but you keep escaping... where are the other, small remarks on the other PR's? 😅