search

Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.66k stars 876 forks source link

[CURA-11084] Add missing 'perform_prime' member-variable. #1960

Closed rburema closed 9 months ago

rburema commented 9 months ago

Note that this needs the updated GRPC definitions as well! -- This caused that variable to always be (re)set to false, even when no plugin was present, due to the 'identity' conversion taking place. (Maybe we should stop that in general, since that implies that we copy the data even when no plugin is present.) In any case, even if it wouldn't have caused this particular bug, it's an oversight that should be fixed anyway.

See also: https://github.com/Ultimaker/CuraEngine_grpc_definitions/pull/13

github-actions[bot] commented 9 months ago

Unit Test Results

0 tests   - 26   0 :heavy_check_mark:  - 26   0s :stopwatch: -13s 0 suites  -   1   0 :zzz: ±  0  0 files    -   1   0 :x: ±  0 

Results for commit d78bb6de. ± Comparison against base commit c2139cfa.