search

Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.66k stars 874 forks source link

[CURA-11293] fix disallowed areas #1980

Closed wawanbreton closed 8 months ago

wawanbreton commented 8 months ago

Machine disallowed areas dimensions are always expressed in zero-centered coordinates. However, the engine always converted them back to front-left-centered coordinates. But in cases where all the coordinates are expressed in zero-centered, is it not required to convert them, which leads to disallowed ared being shifted over the build plate.

CURA-11293

github-actions[bot] commented 8 months ago

Unit Test Results

26 tests  ±0   26 :heavy_check_mark: ±0   14s :stopwatch: ±0s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 52ee9bc8. ± Comparison against base commit eeb93cfa.

:recycle: This comment has been updated with latest results.

casperlamboo commented 8 months ago

also pr is made into main, should be 5.6?

wawanbreton commented 8 months ago

also pr is made into main, should be 5.6?

:+1: