Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.66k stars 874 forks source link

[CURA-11359] sanitize code #1986

Closed wawanbreton closed 7 months ago

wawanbreton commented 7 months ago

The main purpose of this PR is to remove all the compilation warnings issued when using the enable_extensive_warnings option is set. On the currant master branch, there are 16000+ warnings which makes it completely impossible to use them relevantly.

Most notable changes made:

Some parts of the code have become less readable, especially because of the numbers conversions. This emphasizes a global code issue that various types are used and mixed together, which should not happen. This should be fixed along the way.

github-actions[bot] commented 7 months ago

Unit Test Results

26 tests  ±0   26 :heavy_check_mark: ±0   6s :stopwatch: ±0s   1 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit fad6bd5a. ± Comparison against base commit 537f1c2f.

:recycle: This comment has been updated with latest results.

casperlamboo commented 7 months ago

Also, there are some merge conflicts