Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.68k stars 882 forks source link

Feature issue 15583 spiral z hop #1995

Open NadineMik opened 10 months ago

NadineMik commented 10 months ago

Description

This pull requests adds a tangential spiral z-hop and thus fixes this issue. It provides a smooth spiral z-hop after a retraction, where the beginning and the end of the spiral (or arc) is tangential to the previous and following movement. Additionally, a retraction can be performed throughout the spiral. The z-height increases linearly throughout the spiral and the speed in xy-direction is kept constant relative to the previous movement. After the following travel a normal unretract and vertical un-z-hop is performed. The full documentation on this feature can be found over here. This pull request is paired with a pull request in cura over here.

Type of change

How Has This Been Tested?

Test Configuration:

Checklist:

jellespijker commented 7 months ago

Hi,

Thank you for taking the time to contribute. We're in the progress of updating our Way-Of-Working with regards to PR's so I'm adding some label(s). That way we can prioritize our work-load and give your PR the love it deserves.

Either I our one of my colleagues will pick this up in the near future

saumyaj3 commented 5 months ago

Hey @NadineMik ! I have created a branch and a PR based on your PR https://github.com/Ultimaker/CuraEngine/pull/2076, to test the feature. I'd like you to please take a look at the benchmarks. You can find benchmark results here: https://github.com/Ultimaker/CuraEngine/actions/runs/8891872064/job/24414747014?pr=2076 image

NadineMik commented 4 months ago

Hey @NadineMik ! I have created a branch and a PR based on your PR #2076, to test the feature. I'd like you to please take a look at the benchmarks. You can find benchmark results here: https://github.com/Ultimaker/CuraEngine/actions/runs/8891872064/job/24414747014?pr=2076 image

Hi @saumyaj3, thanks for pointing this out. There was a minor mistake in two of the gtest macro calls. I corrected it and pushed it to the branch in my fork. All checks which ran are pass now.