search

Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.68k stars 882 forks source link

CURA-11392-including-threshold-setting-for-ppr #1996

Closed saumyaj3 closed 9 months ago

saumyaj3 commented 9 months ago

CURA-11392

for internal printers, Introduce Threshold settings for Printjobs so it can be taken into account for print progress reporting

rburema commented 9 months ago

GCode-analyzer failing, probably because it has the wrong version of Cura checked out. Should go alright if we merge this after the Cura branch is merged.

jellespijker commented 9 months ago

Why is this in the engine? This could be implemented in the front-end with the formula's in the start/end gcode

rburema commented 9 months ago

@jellespijker The rest of the Griffin-header is also done in the engine. If we want to do it that way, I'd propose moving it over wholesale.

    case EGCodeFlavor::GRIFFIN:
        prefix << ";START_OF_HEADER" << new_line_;
        prefix << ";HEADER_VERSION:0.1" << new_line_;
        prefix << ";FLAVOR:" << flavorToString(flavor_) << new_line_;
        prefix << ";GENERATOR.NAME:Cura_SteamEngine" << new_line_;
        prefix << ";GENERATOR.VERSION:" << CURA_ENGINE_VERSION << new_line_;
        prefix << ";GENERATOR.BUILD_DATE:" << Date::getDate().toStringDashed() << new_line_;
        prefix << ";TARGET_MACHINE.NAME:" << transliterate(machine_name_) << new_line_;
jellespijker commented 9 months ago

yes, but these are also for a subset of printers that use the griffin header.