search

Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.68k stars 882 forks source link

[CURA-11157] Remove 'support_interface_skip_height' setting #2009

Closed rburema closed 8 months ago

rburema commented 8 months ago

Was used for run-time efficiency, but it wasn't really ever set beyond one layer-height, which made it rather useless.

For the frontend PR see https://github.com/Ultimaker/Cura/pull/17961

casperlamboo commented 8 months ago

Why not completely remove all references to skip layer height instead of defaulting it to 1 (see https://github.com/Ultimaker/CuraEngine/pull/2010). I think by leaving the references to "old unused features" we unnecessarily increase the complexity of the engine.

rburema commented 8 months ago

@casperlamboo Good point -- I didn't want to alter too much in this ticket, but perhaps it can be done simply. Let me have a look.

rburema commented 8 months ago

Done!