Closed jellespijker closed 8 months ago
Minor suggestions again. I am also in favor of creating a ticket to fix the sentry sink (which should not be too difficult)
can you create the Jira ticket for me?
can you create the Jira ticket for me?
CURA-11549
Description
Removed the Sentry Spdlog Sink, this was corrupting the Sentry data on most occasions, resulting in dropped Sentry issues. Since this was a nice to have feature I opted for dropping support at this time. If it turns out we are missing valuable information I propose that we make a ticket for this on the backlog.
Integrated Sentry uploading step in the build scripts. This will upload the debug and source files giving us quite a detailed Issue report, this should also result in better merging of Sentry events.
Integrated Sentry release step in the build scripts. This will mark a Sentry release for CuraEngine specifying the commit. This gives us the diff between previous releases and marks who worked on the commits. This should allow Sentry to give better hints when a bug was introduced.
The environmental variable
CURAENGINE_SENTRY_USER
is now the actual user name, which can either be provided on the shell environment or set by Cura if a logged in DF user opts-in for this feature. This will help us to quickly find our own crashes and those of colleagues. Or in the future DF customersType of change
How Has This Been Tested?
Test Configuration:
Checklist: