Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.

https://ultimaker.com/en/products/cura-software

GNU Affero General Public License v3.0

1.66k stars 874 forks source link

Fix travel length regression #2036

Closed casperlamboo closed 4 months ago

casperlamboo commented 4 months ago

Description

We found a regression regarding travel-lengths in the gcode analyzer. The regression was caused by this commit: https://github.com/Ultimaker/CuraEngine/commit/8be88c26a10476832ccccebd8d0d1234d6fbc8d1. This PR resolves the regression while still implementing the engine crash fix in the a fore mentioned commit.

CURA-11653

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Yes

Test Configuration:

Operating System: macOS 13.3

Checklist:

[x] My code follows the style guidelines of this project as described in UltiMaker Meta
[x] I have read the Contribution guide
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have uploaded any files required to test this change

saumyaj3 commented 4 months ago

LGTM