search

Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.66k stars 874 forks source link

Cura 9838 brim location #2040

Closed wawanbreton closed 3 months ago

wawanbreton commented 4 months ago

This PR adds the ability to generate a brim outside a model, inside or both. For this to work, I had to partially rewrite the brim generation because we cannot treat single holes when they are not part of an outer shape. The brim has interactions with the draft/ooze shields, and also with supports, so those parts were also impacted. And finally, this opened new edge-case that were previously impossible, so more fixes were required. In the end, this is a pretty big PR with a lot of geometric logic. I added documentation where I felt it was required, but feel free to ask for more.

Comes along with https://github.com/Ultimaker/Cura/pull/18466

wawanbreton commented 4 months ago

The faulty case has been fixed with 7b6906a, a margin was indeed missing for supports brim