Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.66k stars 874 forks source link

Fix support on top of interface #2049

Closed casperlamboo closed 3 months ago

casperlamboo commented 3 months ago

Description

Due to newly added fractional layer height, in combination with the extremely small model height (1 layer) the model was completely missed in the logic that added the roof logic. Added one additional layer in the for loop that checks for model area's in the interface logic to take into account fractional layers. Also removed the "skip layers" logic as this was just a performance optimization that was adding a lot of unneeded complexity in my opinion.

Before Screenshot 2024-03-18 at 17 19 24

After Screenshot 2024-03-18 at 17 18 29

CURA-11423

Type of change

How Has This Been Tested?

yes

Test Configuration:

Checklist: