Due to newly added fractional layer height, in combination with the extremely small model height (1 layer) the model was completely missed in the logic that added the roof logic. Added one additional layer in the for loop that checks for model area's in the interface logic to take into account fractional layers. Also removed the "skip layers" logic as this was just a performance optimization that was adding a lot of unneeded complexity in my opinion.
Before
After
CURA-11423
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
How Has This Been Tested?
yes
Test Configuration:
Operating System: macos 13.3
Checklist:
[x] My code follows the style guidelines of this project as described in UltiMaker Meta
Description
Due to newly added fractional layer height, in combination with the extremely small model height (1 layer) the model was completely missed in the logic that added the roof logic. Added one additional layer in the for loop that checks for model area's in the interface logic to take into account fractional layers. Also removed the "skip layers" logic as this was just a performance optimization that was adding a lot of unneeded complexity in my opinion.
Before![Screenshot 2024-03-18 at 17 19 24](https://github.com/Ultimaker/CuraEngine/assets/6638028/284cb639-8873-4614-bc10-72a3baf84de8)
After![Screenshot 2024-03-18 at 17 18 29](https://github.com/Ultimaker/CuraEngine/assets/6638028/a234b740-1014-4b4e-95ec-c8bef8c7d17b)
CURA-11423
Type of change
How Has This Been Tested?
yes
Test Configuration:
Checklist: