Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.66k stars 871 forks source link

[CURA-9474] (Some) Seams Not On Vertices #2087

Closed rburema closed 1 week ago

rburema commented 1 month ago

Make it possible to have seams for the walls not on vertices, when user-specified or shortest is selected as a seam-type.

Still to do; Figure out if this approach is robust and extensive enough, and make a new setting in the frontend (either a truly new one, or I suppose this could be a 'corner preference').

user_specified

EDIT: Now also with accompanying front-end PR: https://github.com/Ultimaker/Cura/pull/19188

smartavionics commented 1 month ago

FYI, what I did was enable this feature when the z-seam corner preference was "none" and a z-seam hint position has been specified. I generate a line that extends from the middle of the mesh to the z-seam hint location and where that line crosses the wall, put the z-seam.

rburema commented 4 weeks ago

@smartavionics Thanks, that makes sense -- I'll have to experiment a bit more anyway (depending on how far my current idea takes me), I might try your method.

rburema commented 1 week ago

Outcome of discussion on our side: We'll merge this now & make a follow up to alter the algo to what smartavionics suggested ~a tiny bit~ later.