Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.

https://ultimaker.com/en/products/cura-software

GNU Affero General Public License v3.0

1.66k stars 871 forks source link

Fix Tree-support lines overlapping with the model #2088

Open ThomasRahm opened 4 weeks ago

ThomasRahm commented 4 weeks ago

Description

Fixes https://github.com/Ultimaker/Cura/issues/18970 by keeping holes if they overlap with the model. Technically this does cause floating lines, but that is in my opinion better than the alternative. There could be an argument made to only apply this if the support density is > 0%, but I do not know if there could be other issues caused by model areas being inside of a support area.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[x] Project file in issue 18970

Test Configuration:

Operating System: Windows 10

Checklist:

[x] My code follows the style guidelines of this project as described in UltiMaker Meta
[x] I have read the Contribution guide
[x] I have commented my code, particularly in hard-to-understand areas