Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.7k stars 886 forks source link

Add engine info handler for getting engine version and hash #2146

Closed saumyaj3 closed 1 month ago

saumyaj3 commented 1 month ago

Implemented a handler for the --engine_info_cb flag to handle engine information retrieval. Added functionality to create and send engine info messages, which include the Cura engine version and hash, to Emscripten. Updated CMake and conan files to pass Cura engine hash.

NP-349

wawanbreton commented 1 month ago

Do you need this in 5.9 ? If not, it is preferable to keep it in main.

jellespijker commented 1 month ago

Do you need this in 5.9 ? If not, it is preferable to keep it in main.

Neoprep will be based on 5.9, so yes we need it in the release branch. @saumyaj3 needs to base it from 5.9 it that scenario.

I don't think there will be any risk for Cura with merging it since the changes are in the Emscripten communication class, which will not be compiled for desktop applications

saumyaj3 commented 1 month ago

I changed it to 5.9 branch

jellespijker commented 1 month ago

@saumya did you also base it from 5.9? otherwise we will pull in main into 5.9

saumyaj3 commented 1 month ago

I started working from main. The package created is also from main. I can also recreate the packages