Ultimaker / CuraEngine

Powerful, fast and robust engine for converting 3D models into g-code instructions for 3D printers. It is part of the larger open source project Cura.
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
1.69k stars 887 forks source link

CURA-12164 Fix innerwall seam position #2148

Closed wawanbreton closed 1 month ago

wawanbreton commented 1 month ago

This PR actually contains a few different works:

:warning: This introduces some behavior changes of the existing seam selection strategy. Although they are more logical (no more depending on hidden settings) and more explainable, they do change the results of situations people probably got used to.

wawanbreton commented 1 month ago

Possible performance regression was detected for benchmark 'C++ Benchmark'.

I do not see such a difference on my PC, and the code being run for this test hasn't been touched. For now I'll assume this was a hiccup of the runner, and will keep an eye on this.