Better handling of inconsistent property values

Ultimaker / Uranium

A Python framework for building Desktop applications.

GNU Lesser General Public License v3.0

323 stars 185 forks source link

Better handling of inconsistent property values #919

Closed wawanbreton closed 10 months ago

wawanbreton commented 10 months ago

Commit https://github.com/Ultimaker/Uranium/commit/4f328198c4cca4b3f0f7af82f7b81faa5e8479a1 fixes exceptions where an empty string would be set to a floating-point property value. However, in some cases it prevents the values being intentionally set to an empty string (for properties that are actual string). This fix introduces an other way of handling this issue.

CURA-11215

github-actions[bot] commented 10 months ago

Unit Test Results

2 406 tests ±0 2 391 :heavy_check_mark: ±0 27s :stopwatch: -4s       1 suites ±0     15 :zzz: ±0       1 files ±0       0 :x: ±0

Results for commit b74edbd9. ± Comparison against base commit 66907d2e.

:recycle: This comment has been updated with latest results.