CURA-7812-decrease-Qml-singletons

Ultimaker / Uranium

A Python framework for building Desktop applications.

GNU Lesser General Public License v3.0

323 stars 185 forks source link

CURA-7812-decrease-Qml-singletons #933

Closed saumyaj3 closed 8 months ago

saumyaj3 commented 8 months ago

CURA-7812 Delete and refactor a number of singletons in QML to clean up the code. Document the refactor decisions made in the SDK documentation. Deleted: (Deprecated) QualityManagementModel MaterialManagementModel QualityProfilesDropDownMenuModel SimpleModeSettingsManager MachineActionManager UM.Application CustomQualityProfilesDropDownMenuModel

Merged: (also deprecated) WorkspaceFileHandler (merged with meshfile ) OperationStack (merge with actions) ActiveTool (merge with Controller)

fieldOfView commented 8 months ago

Doesn't removing these singletons constitute a rather big API break?

saumyaj3 commented 8 months ago

Doesn't removing these singletons constitute a rather big API break?

Hey @fieldOfView Thanks for pointing it out. The work is in progress to fix it. Converted the PR to draft