Ultimaker / Uranium

A Python framework for building Desktop applications.
GNU Lesser General Public License v3.0
323 stars 185 forks source link

[CURA-12067] The json-decorator-scope didn't set the user-agent yet. #962

Closed rburema closed 4 weeks ago

rburema commented 4 weeks ago

Add the header-dictionaries from base (which should've got the User-Agent set, at the very least in case we wrap around something that inherits from DefaultUserAgentScope, which is the only use-case I encountered) with the json-specific settings that are already in there. In order to prevent breaking the API, don't directly change the inheritance of the JsonDecoratorScope, but instead check for the existence of the header-dict in the base.