search

Ultimaker / cura-build-environment

CMake project to build dependencies for Cura
GNU Affero General Public License v3.0
24 stars 55 forks source link

Fixing Windows 32-bit builds #30

Closed thopiekar closed 6 years ago

thopiekar commented 6 years ago

This commit adds CMAKE_MINGWC_COMPILER_ARG1 and CMAKE_MINGW_CXX_COMPILERARG1, which are not passed to Microsoft's compilers compared if you use CMAKE*_COMPILER_ARG1.

Also other minor changes will land here..

Test for https://github.com/Ultimaker/cura-build-environment/pull/30/commits/d6cbb874b89663b4ee0233ff5cb9939492164535 : https://thopiekar.eu:5443/Cura/cura-build-environment/pipelines/25 Test for https://github.com/Ultimaker/cura-build-environment/pull/30/commits/d93b7217b584252e123f10409d35446c6679eec6 : https://thopiekar.eu:5443/Cura/cura-build-environment/pipelines/30

ChrisTerBeke commented 6 years ago

We officially dropped 32 bit support, mostly because those pc's are too slow to run Cura in a user-friendly way, but also so we don't have to test/maintain on platforms that none of us still work on (all on 64 bit here). So while we value this contribution, I don't think we're gonna support it ourselves.