Fix build with Python 3.8 and --no-undefined linker flags

Ultimaker / libArcus

Communication library between internal components for Ultimaker software

GNU Lesser General Public License v3.0

72 stars 81 forks source link

Fix build with Python 3.8 and --no-undefined linker flags #113

Closed StefanBruens closed 3 years ago

StefanBruens commented 3 years ago

Currently the build uses the CMAKE_SHARED_LINKER_FLAGS for both the libArcus shared library as well as the Python module. Starting with Python 3.8 the Python module is no longer linked to libpython, and thus some symbols stay undefined.

The correct build type for python modules is "MODULE", which uses the distinct CMAKE_MODULE_LINKER_FLAGS. This allows to keep the '-Wl,--no-undefined' linker flag for libArcus.

See https://github.com/Ultimaker/libArcus/pull/109

StefanBruens commented 3 years ago

Ping!

rburema commented 3 years ago

@StefanBruens sorry it took a while!

Devs: Linkback to internal ticket CURA-8388