search

Ultimaker / libArcus

Communication library between internal components for Ultimaker software
GNU Lesser General Public License v3.0
75 stars 81 forks source link

Allow Cmake to use FindPython3 #116

Closed jellespijker closed 3 years ago

jellespijker commented 3 years ago

This allows us to use FindPython3 if the cmake version is higher or equal to 3.12. Which allows a user to set -DPython3_FIND_VIRTUALENV=ONLY such that the library can be installed in a virtual environment (mostly useful on Mac and Windows machines). This commit doesn't break the current behavior of our CI machines.

This will also make this repository future ready when we finally do update cmake.

konskarm commented 3 years ago

Tested this with CMake 3.16 and it finds Python3 without an issue. It shouldn't affect the build server with CMake < 3.12, since there is no change there.