Limit library symbol visibility on all platforms

Ultimaker / libArcus

Communication library between internal components for Ultimaker software

GNU Lesser General Public License v3.0

75 stars 81 forks source link

Limit library symbol visibility on all platforms #98

Closed onitake closed 5 years ago

onitake commented 5 years ago

This PR implements the suggested changes in #80 .

It compiles fine on Linux/amd64/gcc8.3.0 and clang7.0.1 and the example executes fine. The resulting library was not tested against other Cura components, however.

Ghostkeeper commented 5 years ago

It seems I had done something wrong when applying your patch initially, then, because this PR does compile (including the examples). It's not working yet when compiling CuraEngine with it though. I think it's missing the headers there, possibly just on my system. I'm debugging that now.

Ghostkeeper commented 5 years ago

I had to make one modification to get this to work: https://github.com/Ultimaker/libArcus/commit/734d2eac9c5341eef683c8c41f603573373743c2

onitake commented 5 years ago

Good catch! I totally forgot about the installation of the generated file.