search

Ultimate-Hosts-Blacklist / Ultimate.Hosts.Blacklist

The Ultimate Unified Hosts file for protecting your network, computer, smartphones and Wi-Fi devices against millions of bad web sites. Protect your children and family from gaining access to bad web sites and protect your devices and pc from being infected with Malware or Ransomware.
MIT License
1.24k stars 155 forks source link

No longer rely on the presence of bash #605

Closed ngaro closed 2 years ago

ngaro commented 3 years ago

Although bash is available in most distributions, this is not always the case. A notable example are docker containers based on Alpine linux it's more often missing than present. This PR makes sure it works everywhere by relying on a shell instead of a specific shell.

The FHS defines that if the system has shells (1 or more), at least one of them should be in /bin. So the forced location is not a problem.

The script itself doesn't need any change, it always does exactly the same. It doesn't matter if you use bash, zsh, csh or even busybox.

funilrys commented 3 years ago

I will merge this first, then #608. Therefore, it shouldn't be a problem. Or did I miss something?

Thank you for the feedback!