UltimateHackingKeyboard / agent

Ultimate Hacking Keyboard configurator
https://ultimatehackingkeyboard.github.io/agent/
Other
692 stars 77 forks source link

feat: macro command syntax highlight and auto-completion #2270

Closed ert78gb closed 1 month ago

ert78gb commented 1 month ago

It is almost done. thx for the prev PR @kareltucek. I think would be better to move the typescript of the naive-autocompletion-parser to the dev dependencies because typescript not really need as runtime/package dependency.

@mondalaci @kareltucek Please play with it.

mondalaci commented 1 month ago

The syntax highlighting and autocompletion look very cool and helpful. That's all I can say, but I'm not a heavy smart macro user.

Feel free to move naive-autocompletion-parser to devDependencies.

kareltucek commented 1 month ago

thx for the prev PR @kareltucek.

Thanks for finishing and refactoring the PR!

I think would be better to move the typescript of the naive-autocompletion-parser to the dev dependencies because typescript not really need as runtime/package dependency.

Feel free to!


As for my testing, it works like a charm!

I am satisfied with it and think that this can be merged.

For the sake of completeness, as a heavy macro user, I will note known limitations:

mondalaci commented 1 month ago

@ert78gb I'll merge this as soon as you commit the devDependencies change.

@kareltucek I'd like to prioritize important firmware-related issues now, but feel free to implement improvements later, especially the easy ones.