Closed mondalaci closed 7 years ago
It was because of electron-builder. I've updated it, now it should work. For the long term solution I will try to come up with something.
@fjozsef Works like a charm, you're the man!
As for the long term solution, maybe hardcoding package.json version numbers is not the best way. How about using package-lock.json? Any alternatives are welcome.
I keep this issue open to discuss the best solution.
I use yarn
which is 10 times faster and has the same lock file approach which also should be checked in 😎
Good point, @attilacsanyi! Wondering whether we should move to yarn. I read however that npm 5 matches and maybe surpasses the speed of yarn, so maybe it's not beneficial.
Just another note guys, i experienced the same npm install issue, which was resolved with both clearing node_modules
and update node
version to the latest.
For package versions i always use specific version numbers and upgrade only if i have already tested the app, so i can avoid the situation when another developer automatically install newer version due to ^
npm versioning.
Any lock file solution (yarn or npm 5) also help in this to freeze the dependency tree.
It looks like we can't shrinkwrap it, because of an unmeet peer dependecy of ng2-select2.
ng2-select2@1.0.0-beta.10 requires a peer of @angular/core@^2.2.0 but none was installed.
The npm 5 is good for me. Did you tried build the app with node 8.x? I did not have time, yet. I think the long term solution is a greenkeeper.io. But need fully automata tested app for it. Short term solution fix many package version that is possible.
@ert78gb I haven't tried node 8.x yet, but @fjozsef is just looking into it. npm 5 is probably the way to go. It'll automatically update package.json and package-lock.json which will solve issues like this one.
Our postinstall script fails on windows with node v8.1.2 and npm 5.0.3. We should wait for a newer version which fix the problem.
Why we don't freeze the version of all package? I will do it just approve it :)
@fjozsef under Mac npm install is fine
We have to make a decision which node version we will use under test end development.
@attilacsanyi It is a windows only bug.
@ert78gb According to my knowledge it's not possible to freeze package versions due to some misbehaving packages. Would you elaborate about it, @fjozsef?
http://jpospisil.com/2017/06/02/understanding-lock-files-in-npm-5.html "Note that pointing to a specific version of a dependency in package.json is not good enough because you want to make sure the end users get the exact same dependency tree including all of its sub-dependencies. A specific version in package.json guarantees the version only at the top level."
@eltang has just reported that he cannot build Agent, so I freshly cloned it and reproduced the same issue that he reported. Can you look into it, @fjozsef, @ert78gb, @attilacsanyi?
Apart from solving this specific issue, I'd like to make sure this will never happen again. According to my knowledge, Agent got broken due to external circumstances. Should we hardcode the versions of our dependencies, or can you see any other solution?
@eltang cannot develop the firmware because of this issue, so I'd like this wrapped up as soon as possible. Thanks in advance, guys!