UltimateHackingKeyboard / firmware

Ultimate Hacking Keyboard firmware
Other
420 stars 66 forks source link

Add delete navigation mode. #712

Closed kareltucek closed 1 year ago

kareltucek commented 1 year ago

Someone mentioned this on the forum, and it seems a very nice idea to me, so here we go?

mondalaci commented 1 year ago

I think this feature is too niche, and line deletion doesn't work in Visual Studio Code as it's dependent on the shortcuts of the editor, making it potentially problematic.

kareltucek commented 1 year ago

This is not a new feature. It is just adding another remappable slot to the navigation mode system ¯\(ツ)/¯.

As to line deletion, it is that, or leaving the up/down shortcuts empty...

mondalaci commented 1 year ago

If another caret mode is justified, a more general name would make better sense to me, like caret2.

But I'm not sure if this feature is justified, to begin with.

kareltucek commented 1 year ago

Allright, let's close it then?

mondalaci commented 1 year ago

Yes, I prefer to close this one.

As a rule of thumb, I'd only add features to smart macros that clearly provide value to a fair number of users. Otherwise, we're adding complexity that users must absorb, and simplicity is a feature.

Admittedly, the above is not a strict definition, but I think this feature is below the acceptance threshold.