UltimateHackingKeyboard / firmware

Ultimate Hacking Keyboard firmware
Other
420 stars 66 forks source link

Add module and some other settings to user configuration #733

Closed mondalaci closed 8 months ago

mondalaci commented 11 months ago

Instead of moduleConfigurationCount = ReadCompactLength(buffer); let's use a uint8_t because we'll never exhaust it. Its value has always been zero so far.

Please rewrite parseModuleConfiguration() according to the following. (It has never been used so far because Agent serialized an empty module array, so backward compatibility is not an issue.)

Add the following to the user configuration to positions where they're consistent with already existing properties:

kareltucek commented 11 months ago

What will be the new config version?

mondalaci commented 11 months ago

This being a breaking change, the new user config version is 7.0.0