Fix composite shortcuts in caret mode.

UltimateHackingKeyboard / firmware

Ultimate Hacking Keyboard firmware

Other

410 stars 63 forks source link

Fix composite shortcuts in caret mode. #743

Closed kareltucek closed 5 months ago

kareltucek commented 5 months ago

Closes #730.

Steps to reproduce:

Add the following into your $onInit:

set navigationModeAction.caret.left none
set navigationModeAction.caret.right none
set navigationModeAction.caret.up keystroke LS-U
set navigationModeAction.caret.down keystroke LS-D
set keystrokeDelay 10

Now press fn and swipe with your right hand module.
Observe output like uuuuuuuuuUddddddddduuuuuddddduuDDDDdddDuuuuu.
Apply this fix.
Observe output like UUUUDDDDDDDDDDUUUUUUUUUDDDDDDDDUUUUDDDDDDDDUUUU

mondalaci commented 5 months ago

    CC    usb_command_get_device_property.c
    CC    usb_command_get_module_property.c
    LD    uhk60v2.axf

/usr/lib/gcc/arm-none-eabi/10.3.1/../../../arm-none-eabi/bin/ld: build_make//home/laci/projects/firmware/lib/KSDK_2.0_MK22FN512xxx12/devices/MK22F51212/gcc/startup_MK22F51212.o: in function `Reset_Handler':
(.text+0x60): undefined reference to `data2_at'
/usr/lib/gcc/arm-none-eabi/10.3.1/../../../arm-none-eabi/bin/ld: (.text+0x64): undefined reference to `data2_start'
/usr/lib/gcc/arm-none-eabi/10.3.1/../../../arm-none-eabi/bin/ld: (.text+0x68): undefined reference to `data2_end'
Memory region         Used Size  Region Size  %age Used
    m_interrupts:          1 KB         1 KB    100.00%
          m_text:      112136 B       463 KB     23.65%
          m_data:       54104 B        64 KB     82.56%
        m_data_2:       58720 B      65280 B     89.95%
        m_noinit:          16 B        255 B      6.27%
collect2: error: ld returned 1 exit status
make: *** [../../scripts/Makedefs.mk:203: build_make/uhk60v2.axf] Error 1

kareltucek commented 5 months ago

Yep, applies to all open PRs :D