Key timing hunt rebased

[kareltucek]

Changelog:

• advanced strategy revised: safety-margin-related behavior might have changed
• added secondaryRole.advanced.triggerByMouse config value. Advanced secondary roles are now not triggered by mouse movement by default.
• added secondaryRole.advanced.triggerByPress config value.

Closes #746 . Implements https://github.com/UltimateHackingKeyboard/agent/issues/792 .

[mondalaci]

Can I merge this, or do you want to change anything else?

[kareltucek]

You can merge it!

[mondalaci]

Regarding #746, please summarize the issue and provide the easiest steps to reproduce it. There are a lot of forum comments in the related thread, I get lost, and I have to deal with a lot.

[kareltucek]

• Map a lot of secondary roles on alphanumeric keys on base layer.
• Connect your trackball module.
• Set advanced secondary roles as follows:

  set secondaryRole.defaultStrategy advanced
  set secondaryRole.advanced.timeout 1000
  set secondaryRole.advanced.timeoutAction secondary
  set secondaryRole.advanced.safetyMargin 0
  set secondaryRole.advanced.triggerByRelease 0

• This way, no secondary roles should activate unless you press the key for at least a second.
• Now, give it 15 minutes of hard typing. I mean, bang the keys really hard.
• If you are lucky, some secondary role activates for no apparent reason. (The reason is small movement of the ball caused by your typing.)

Alternatively:

• Map some secondary role on your base layer
• Set advanced secondary roles as follows:

  set secondaryRole.defaultStrategy advanced
  set secondaryRole.advanced.timeout 1000
  set secondaryRole.advanced.timeoutAction secondary
  set secondaryRole.advanced.safetyMargin 0
  set secondaryRole.advanced.triggerByRelease 0

• Tap the key and simultaneously move the cursor using your module.
• Observe secondary role getting activated. In this case, it might be desired, or not. We operate with the assumption that it is not desired. If it is, then you have the option to allow it using the set secondaryRole.advanced.triggerByMouse 1 option.